[ 
https://issues.apache.org/jira/browse/CB-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186018#comment-14186018
 ] 

ASF GitHub Bot commented on CB-7868:
------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-js/pull/88

    CB-7868 Use utils.defineGetterSetter instead of Object.defineProperty 

    Object.defineProperty is not available on some android versions.  Our own 
util function checks this, so we should just call it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-js CB-7868

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #88
    
----
commit bd5a35fac8ce04deda9317831aea3a4489b9fc33
Author: purplecabbage <[email protected]>
Date:   2014-10-27T22:56:01Z

    CB-7868 Use utils.defineGetterSetter instead of Object.defineProperty which 
may or may not be defined

----


> Cordova [email protected] is broken for some Android versions (Javascript)
> ----------------------------------------------------------------------
>
>                 Key: CB-7868
>                 URL: https://issues.apache.org/jira/browse/CB-7868
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaJS
>    Affects Versions: 4.0.0
>         Environment: Android >= 2.3.6 && <= 4.0.3 
>            Reporter: Boris Fersing
>
> Cordova 3.6.4 breaks the compatibility with some versions of Android. The app 
> won't load
> I've been able to reproduce the bug on my 2.3.6 and 2.3.7 devices, and 
> according to some bug reports I found, this might also affect other Android 
> versions <= 4.0.3 but I did not have the opportunity to test those platforms.
> The bug has been introduced in this commit:  
> https://github.com/apache/cordova-android/commit/025ca36d3ad0e2acb5c496442a661e3759b30af3
> And the culprit is the Object.defineProperty method that is broken on the 
> platforms I mentioned above. (see  https://github.com/cujojs/poly/issues/29 )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to