[ 
https://issues.apache.org/jira/browse/CB-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189634#comment-14189634
 ] 

ASF GitHub Bot commented on CB-7896:
------------------------------------

Github user sgrebnov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-contacts/pull/49#discussion_r19587554
  
    --- Diff: tests/tests.js ---
    @@ -99,7 +110,14 @@ exports.defineAutoTests = function () {
                   afterEach(removeContact);
     
                   it("contacts.spec.6 should be able to find a contact by 
name", function (done) {
    -                  if (isWindowsPhone) {
    +                  // Find method is not supported on Windows Store apps.
    +                  // also this test will be skipped for Windows Phone 8.1 
because function "save" not supported on WP8.1
    +                  if (isWindows) {
    +                      pending();
    +                      return;
    +                  }
    +
    +                  if (isWindowsPhone8) {
    --- End diff --
    
    Why done() w/o running any tests?


> Some tests for plugin contacts are fails for windows because methods are not 
> supported
> --------------------------------------------------------------------------------------
>
>                 Key: CB-7896
>                 URL: https://issues.apache.org/jira/browse/CB-7896
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: mobile-spec, Plugin Contacts, Windows
>            Reporter: Maria Bukharina
>
> Repo steps:
> 1. create mobile-spec app
> 2. run Plugin auto test for plugin contacts
> Expected: if method doesn't siupport pending test
> Actual: tests for "Find" and "Save" methods are failed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to