[
https://issues.apache.org/jira/browse/CB-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198999#comment-14198999
]
ASF GitHub Bot commented on CB-7937:
------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/52
CB-7937 - Re-factor iOS Camera plugin so that it is testable
there will be a follow-up PR for
https://issues.apache.org/jira/browse/CB-7938
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-plugin-camera CB-7937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit dc2d7c580115df3ec2e5911924022b51e5e314ca
Author: Shazron Abdullah <[email protected]>
Date: 2014-11-05T20:19:42Z
CB-7937 - Re-factor iOS Camera plugin so that it is testable
----
> Re-factor iOS Camera plugin so that it is testable
> --------------------------------------------------
>
> Key: CB-7937
> URL: https://issues.apache.org/jira/browse/CB-7937
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
> Environment: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> Right now the UIImagePickerController callback is a monolithic mess.
> Re-factor so that it is testable using XCUnit tests. targetSize desperately
> needs unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
