[
https://issues.apache.org/jira/browse/CB-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215070#comment-14215070
]
ASF GitHub Bot commented on CB-8029:
------------------------------------
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/41
CB-8029 test 1-based indexing for confirm
Added to the expected results -- remember to check 1-based indexing in the
confirm manual tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-dialogs CB-8029
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 86b4e25a38c082ddcae1534bfb4f39f8f3819e00
Author: Staci Cooper <[email protected]>
Date: 2014-11-17T19:51:11Z
CB-8029 test 1-based indexing for confirm
Added to the expected results -- remember to check 1-based indexing in the
confirm manual tests.
----
> Add test for 1-based indexing of notification.confirm
> -----------------------------------------------------
>
> Key: CB-8029
> URL: https://issues.apache.org/jira/browse/CB-8029
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec, Plugin Dialogs
> Reporter: Staci Cooper
> Assignee: Staci Cooper
> Priority: Trivial
>
> notification.confirm returns the index of the button pressed using 1-based
> indexing. Requires manual testing.
> Since we already have a manual confirm test, it would suffice to add mention
> of the indexing to the 'Expected Results'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
