[
https://issues.apache.org/jira/browse/CB-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220043#comment-14220043
]
ASF GitHub Bot commented on CB-7858:
------------------------------------
GitHub user MMrko opened a pull request:
https://github.com/apache/cordova-wp8/pull/64
CB-7858 Fix onload="true"
Replace `TakeWhile` with `Where` so that _AutoloadPlugins_ returns all
plugins for which `onload="true"`.
Fixes https://issues.apache.org/jira/browse/CB-7858.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MMrko/cordova-wp8 fix-plugin-onload
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 36282cdb1d26f845482438adbb78c6054dbffcfb
Author: Marko <[email protected]>
Date: 2014-11-20T21:26:20Z
Fix AutoloadPlugins
Replace TakeWhile with Where to return all plugins for which onload="true".
Fixes https://issues.apache.org/jira/browse/CB-7858.
----
> Windows Phone 8 - Unless specified before all other plugins, 'onload=true'
> plugins will not run OnInit()
> --------------------------------------------------------------------------------------------------------
>
> Key: CB-7858
> URL: https://issues.apache.org/jira/browse/CB-7858
> Project: Apache Cordova
> Issue Type: Bug
> Components: WP8
> Affects Versions: 3.5.0
> Reporter: Matthew Simmons
> Assignee: Jesse MacFadyen
> Priority: Minor
>
> On Windows Phone 8,
> WPCordovaClassLib.CordovaLib.ConfigHandler.AutoLoadPlugins contains a LINQ
> query using TakeWhile
> TakeWhile will stop execution once it finds an item that does not match the
> predicate, meaning any autoLoad plugin would have to be specified before all
> other plugins that do not specify autoLoad
> Using Where instead of TakeWhile should fix this issue since Where will
> return all matches
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
