[
https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223616#comment-14223616
]
Andrew Grieve commented on CB-8032:
-----------------------------------
Two things that make me a bit worried about this approach:
1 - Might impact performance. Probably fine though so long as it doesn't apply
to NSData* types.
2 - It's a lossy transformation. E.g.:
- File returns file://blah.
- It then gets turned into http://localhost:8080/filesystem/blah.
- JS then sends the URL back to the plugin.
- The plugin now doesn't understand it because it's expecting a file://
If we apply the reverse transformation (back to file://), then plugins
expecting http://localhost will end up with file://.
I think all this is fine for experimentation, but I think if we're going to
make the local server a supported path, then other plugins will need to know
about it.
> Add nativeURL external method support for
> CDVFileSystem->makeEntryForPath:isDirectory:
> --------------------------------------------------------------------------------------
>
> Key: CB-8032
> URL: https://issues.apache.org/jira/browse/CB-8032
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File
> Transfer, Plugin Media, Plugin Media Capture
> Environment: iOS
> Reporter: Shazron Abdullah
>
> Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the
> NSDictionary that is returned, for the key "nativeURL" the format is fixed
> (file:// protocol for a local filesystem reference, and assets-library:/ for
> a assets library filesystem reference.)
> When calculating the nativeURL, allow this to be specified externally, check
> for a selector "nativeURL" and call that if available.
> This is for example declared in a Category in this plugin:
> https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m
> ... which when linked will have the selector available for the File plugin to
> call.
> This code is part of the local webserver plugin - and it needs the File
> references to be proxied through a local webserver.
> For example if the FileEntry is to:
>
> file://my/package/folder/Documents/foo.txt
> .. the nativeURL would be, with this new category method, and the local
> webserver listening to http://localhost:8080:
> http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
