[
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223643#comment-14223643
]
James Keshavarzi edited comment on CB-8063 at 11/24/14 10:26 PM:
-----------------------------------------------------------------
Pretty sure it's this line thats the problem.
https://github.com/apache/cordova-js/blob/1fc2526faa6197e1637ecb48ebe0f876f008ba0f/src/cordova.js#L205
It use to read like this;
{code}
else if (!isSuccess)
{code}
instead of
{code}
else
{code}
The NO_RESULT use case seems to be falling into the else clause.
Can you please assign the issue to me and i'll put up a fix.
Thanks.
was (Author: jkeshavarzi):
Pretty sure it's this line thats the problem.
https://github.com/apache/cordova-js/blob/1fc2526faa6197e1637ecb48ebe0f876f008ba0f/src/cordova.js#L205
It use to read like this;
else if (!isSuccess)
instead of
else
The NO_RESULT use case seems to be falling into the else clause.
Can you please assign the issue to me and i'll put up a fix.
Thanks.
> CDVCommandStatus.NO_RESULT calls fail on ios
> --------------------------------------------
>
> Key: CB-8063
> URL: https://issues.apache.org/jira/browse/CB-8063
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 4.0.0
> Environment: iOS
> Reporter: James Keshavarzi
>
> Cordova version: 4.1.2
> When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail
> callback gets called for a plugin, when it shouldn't. Previously nothing was
> called in the client (success/fail) and the plugin was free to continue
> execution and later send a status of OK or ERROR as it deemed necessary.
> Sending a NO_RESULT seems to perform the same operations as sending an ERROR,
> which seems wrong.
> The below code ends up calling the fail callback.
> {code}
> pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
> pluginResult.keepCallback = [NSNumber numberWithInt:1];
> [self.commandDelegate sendPluginResult:pluginResult
> callbackId:command.callbackId];
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
