[
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223648#comment-14223648
]
Shazron Abdullah commented on CB-8063:
--------------------------------------
Actually, I'm putting a discussion topic on to the dev@ list to see what to do
since that line affects all platforms.
I *think* the intent is not to call the success callback if NO_RESULT (which is
success).
So it's something like this pseudo-code:
{code}
if (success) {
if (status is OK) {
// call success callback
} else {
// do nothing, NO_RESULT (success)
}
} else {
// call fail callback
}
{code}
> CDVCommandStatus.NO_RESULT calls fail on ios
> --------------------------------------------
>
> Key: CB-8063
> URL: https://issues.apache.org/jira/browse/CB-8063
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 4.0.0
> Environment: iOS
> Reporter: James Keshavarzi
>
> Cordova version: 4.1.2
> When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail
> callback gets called for a plugin, when it shouldn't. Previously nothing was
> called in the client (success/fail) and the plugin was free to continue
> execution and later send a status of OK or ERROR as it deemed necessary.
> Sending a NO_RESULT seems to perform the same operations as sending an ERROR,
> which seems wrong.
> The below code ends up calling the fail callback.
> {code}
> pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
> pluginResult.keepCallback = [NSNumber numberWithInt:1];
> [self.commandDelegate sendPluginResult:pluginResult
> callbackId:command.callbackId];
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
