[
https://issues.apache.org/jira/browse/CB-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227773#comment-14227773
]
ASF GitHub Bot commented on CB-8095:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/53
CB-8095 Adds support for progress events to upload operation
This fixes [CB-8095](https://issues.apache.org/jira/browse/CB-8095)
On windows FileTrasfer doesn't support progress events for upload operation
properly since internal implementation uses XHR which doesn't provide all
information, necessary to fire correct progress events.
This PR replaces XHR with `BackgroundUploader` class which itself supports
progress notification in more convenient way and can provide all necessary data
for progress events for FileTransfer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer
CB-8095
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 970c1cfb4921e4e2a9ec278556c08d759b54bca4
Author: Vladimir Kotikov <[email protected]>
Date: 2014-11-27T15:49:13Z
CB-8095 Rewrite upload method to support progress events properly
* Uses backgroundUploader class instead of XHR
* Returns proper response body in case of error
commit 8bb305e9b9adb4cd52f0441debf3445864559541
Author: Vladimir Kotikov <[email protected]>
Date: 2014-11-27T15:50:01Z
CB-8095 Updates tests and documentation
----
> upload method on windows doesn't support progress events correctly
> ------------------------------------------------------------------
>
> Key: CB-8095
> URL: https://issues.apache.org/jira/browse/CB-8095
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Reporter: Vladimir Kotikov
> Labels: file-transfer, windows
>
> On windows FileTrasfer doesn't support {{progress}} events for upload
> operation properly since internal implementation uses XHR which doesn't
> provide all information, necessary to fire correct progress events.
> Possible solution here is to replace XHR with {{BackgroundUploader}} class
> which itself supports progress notification in more convenient way and can
> provide all necessary data for progress events for FileTransfer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
