[ 
https://issues.apache.org/jira/browse/CB-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229488#comment-14229488
 ] 

ASF GitHub Bot commented on CB-8094:
------------------------------------

Github user sgrebnov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-geolocation/pull/33#discussion_r21073465
  
    --- Diff: tests/tests.js ---
    @@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
             expect(true).toBe(true);
             done();
         };
    +    var isWindowsStore = (cordova.platformId == "windows" && 
navigator.appVersion.indexOf("Windows Phone 8.1;")== -1) || 
(navigator.appVersion.indexOf("MSAppHost/1.0") !== -1)
    --- End diff --
    
    I would recommend to use the following way to detect windows desktop/tablet 
apps
    var isWindowsStore = (cordova.platformId == "windows8") ||  && 
(cordova.platformId == "windows" && !WinJS.Utilities.isPhone)


> Under Windows Store some of geolocation tests requires user interaction and 
> failed by timeout
> ---------------------------------------------------------------------------------------------
>
>                 Key: CB-8094
>                 URL: https://issues.apache.org/jira/browse/CB-8094
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: mobile-spec, Plugin Geolocation
>            Reporter: Maria Bukharina
>
> Under Windows Store auto tests geolocation.spec.5 - 8 asks user permission 
> for use geolocation. So proposed to pend them for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to