[
https://issues.apache.org/jira/browse/CB-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250619#comment-14250619
]
ASF GitHub Bot commented on CB-8114:
------------------------------------
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/133
CB-8114 specify a cache-min-time
Currently there's no caching for plugins while platforms are cached for 1
day. The idea here is to match platform capabilities by setting min-cache
property of NPM for plugman.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #133
----
commit 212360740e26d8d931681f123bf1c534ad4af6ea
Author: Murat Sutunc <[email protected]>
Date: 2014-12-08T23:50:35Z
specify a cache-min-time
----
> Plugin add does not use any minimum cache time
> ----------------------------------------------
>
> Key: CB-8114
> URL: https://issues.apache.org/jira/browse/CB-8114
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Murat Sutunc
> Priority: Trivial
>
> If you do not specify a version number, it works as expected. However it
> fails if you specify a version number
> Output – this is expected (no version number specified):
> C:\Users\muratsu\Documents\cordova\_old\platform-plugin-cache
> > cordova plugin add org.apache.cordova.camera
> Fetching plugin "org.apache.cordova.camera" via plugin registry
> npm http GET http://registry.cordova.io/org.apache.cordova.camera
> npm http GET http://registry.cordova.io/org.apache.cordova.camera
> npm http GET http://registry.cordova.io/org.apache.cordova.camera
> C:\Users\muratsu\Documents\cordova\_old\platform-plugin-cache
> > ls plugins
> org.apache.cordova.camera
> Output – This is not, version number specified (not expected):
> C:\Users\muratsu\Documents\cordova\_old\platform-plugin-cache
> > cordova plugin add [email protected]
> Fetching plugin "[email protected]" via plugin registry
> npm http GET http://registry.cordova.io/org.apache.cordova.camera/0.3.3
> npm http GET http://registry.cordova.io/org.apache.cordova.camera/0.3.3
> npm http GET http://registry.cordova.io/org.apache.cordova.camera/0.3.3
> Error: getaddrinfo ENOTFOUND
> at errnoException (dns.js:37:11)
> at Object.onanswer [as oncomplete] (dns.js:124:16)
> If a specific version is specified and the plugin / platform is in the cache,
> there is no reason to do a lookup in the public repo. Currently plugin add
> fails when offline even if that specific version of the plugin is cached
> locally which doesn't make any sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
