[
https://issues.apache.org/jira/browse/CB-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268806#comment-14268806
]
ASF GitHub Bot commented on CB-8270:
------------------------------------
GitHub user lingoer opened a pull request:
https://github.com/apache/cordova-ios/pull/124
[CB-8270] rename category methods for JSON handling with a prefix.
According to [Apple's
documentation](https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4)
, naming a Category method without a prefix would possibly cause a Name Clash
In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing)
The method name should starts with a prefix
Actually, it clashes with the TencentOpenAPI framework which is a major sns
platform in China.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lingoer/cordova-ios CB-8270
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit 75e72a53f062115066e2fc9305c8dfb0ad5cfeb8
Author: Ruoyu Fu <[email protected]>
Date: 2015-01-08T04:08:37Z
[CB-8270] rename category methods for JSON handling with a prefix.
----
> Objective-C methods on categories should be named with a prefix
> ---------------------------------------------------------------
>
> Key: CB-8270
> URL: https://issues.apache.org/jira/browse/CB-8270
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: Master
> Environment: All iOS platforms
> Reporter: Ruoyu Fu
> Priority: Critical
> Labels: categories, ios, namespace
> Fix For: Master
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> According to Apple's documentation, naming a Category method without a prefix
> would possibly cause a Name Clash
> https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4
> In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing)
> The method name should starts with a prefix
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
