[
https://issues.apache.org/jira/browse/CB-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276311#comment-14276311
]
ASF GitHub Bot commented on CB-8201:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22909913
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
this.appView = view;
helper = new CordovaUriHelper(cordova, view);
}
+
+ /**
+ * Specifies the HTTP auth handler for handling auth challenge
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+ public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --
Right now, almost all plugin hooks are implemented by adding a method to
CordovaPlugin and PluginManager (which loops over all plugins and calls the
corresponding CordovaPlugin method).
Calling plugins based on what interfaces they implement is a neat idea,
although it'd be a new concept to the project. I'm not actually sure if there
are benefits to it or not! Likely we could use that info to improve performance
a bit, but perf isn't an issue atm afaik.
> Add support for auth dialogs into Cordova Android
> -------------------------------------------------
>
> Key: CB-8201
> URL: https://issues.apache.org/jira/browse/CB-8201
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: android, authentication
>
> If you load some resource which requires authentication using android default
> browser default login dialog appears, but if you try to load the same
> resource using cordova app then no dialog is shown for user and request is
> failed w/ 401 Unauthorized. So Currently apps have to provide own JS logic to
> show web based auth dialog.
> It will be great if Cordova Android offers special functionality (in core or
> via special interface plugin developers can extend) to automatically show
> native auth dialog. This is extremely useful in corpnet scenarios where all
> resources requires user to be authenticated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
