[ 
https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277461#comment-14277461
 ] 

Josh Soref commented on CB-7285:
--------------------------------

[~OliverSalzburg]: if you can get this information from the UA already, then 
you should just be logging the UA.

The problem with such a feature is that it encourages developers to write code 
w/ really rough edges.

if (manufacturerA) {
doSomething();
} else if (manufacturerB) {
doSomethingElse();
}

What happens when it's manufacturerC?

Nothing.

the UX is thus awful for that case.

Or what happens when manufacturerA changes its sense of style (which happens 
annually IME).

> Add Manufacturer info to device plugin
> --------------------------------------
>
>                 Key: CB-7285
>                 URL: https://issues.apache.org/jira/browse/CB-7285
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin Device
>            Reporter: Ian Clelland
>            Priority: Minor
>
> bq.For some platforms it makes sense to be able to list the Manufacturer for 
> a device. These changes allow retrieval of manufacturer name for Android, iOS 
> & Blackberry. Have not added to other platforms as I have no access to those 
> or know the API's.
> See https://github.com/apache/cordova-plugin-device/pull/20



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to