[
https://issues.apache.org/jira/browse/CB-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298097#comment-14298097
]
ASF GitHub Bot commented on CB-8382:
------------------------------------
GitHub user agrieve opened a pull request:
https://github.com/apache/cordova-android/pull/152
CB-8382 Make CordovaActivity not implement CordovaInterface
Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agrieve/cordova-android cordova-interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit e27fd72d52b136d820e1e07c86fdcc5cdbf197ad
Author: Andrew Grieve <[email protected]>
Date: 2015-01-30T01:42:44Z
CB-8382 Make CordovaActivity not implement CordovaInterface
Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.
----
> Make CordovaActivity not implement CordovaInterface
> ---------------------------------------------------
>
> Key: CB-8382
> URL: https://issues.apache.org/jira/browse/CB-8382
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Andrew Grieve
> Assignee: Andrew Grieve
> Priority: Minor
>
> CordovaWebView.java used to enforce that they CordovaActivity could be cast
> to a CordovaInterface, but this has been fixed with the move to a two-step
> initialization (separate call to init()).
> With this being fixed, it would clean up the code a bit by shrinking the API
> surface of CordovaActivity. Further, it would ensure that the
> activity==interface assumption does not return.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
