[
https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303127#comment-14303127
]
ASF GitHub Bot commented on CB-8239:
------------------------------------
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-72637685
Hey @agrieve, It seems like the refactoring you did before merging this in
introduced a bug :
Suppose the latest android version is: 3.7.0 and my project contains
android version 3.5.0.
When I run 'cordova platform update android' with my config.xml containing:
<cdv:engine id="android" version="3.6.0" />, my project's android platform is
going to be upgraded to 3.6.0 instead of being upgraded to 3.7.0.
What happens is that it grabs the version from the config.xml if any and
only resorts to the latest pinned version (3.7.0) if the config.xml file is
empty.
> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
> Key: CB-8239
> URL: https://issues.apache.org/jira/browse/CB-8239
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CLI, CordovaLib
> Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add
> https://github.com/apache/cordova-android.git' and the git repo will be
> cloned and used.
> - users can issue 'cordova platform add
> android@https://github.com/apache/cordova-android.git' and the git repo will
> be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file
> contains: '<engine id='android'
> version='https://github.com/apache/cordova-android.git' />, then the git repo
> pointed to by config.xml will be cloned and used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
