[ 
https://issues.apache.org/jira/browse/CB-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303439#comment-14303439
 ] 

Andrew Grieve commented on CB-7518:
-----------------------------------

Hmm, sorry about that. 

There were 2 motives for the change:
1. Many users don't actually have the android-sdk in their PATH, but 
cordova-android looks for it in default install locations to make things work. 
This is certainly doable within plugman as well... but:
2. Plugman should not depend on external tools to do its job. E.g. you should 
be able to create iOS project on windows, you just shouldn't expect to be able 
to build them.

So, what I did here was actually to run do the equivalent of "update 
lib-project" within android's build.js:

https://github.com/apache/cordova-android/blob/ce351f5c38a4fc/bin/templates/cordova/lib/build.js#L137

So it should still be copying in build.xml files, but just not until you go to 
build a project. 

> Android - Don't run "android" command from within CLI/Plugman
> -------------------------------------------------------------
>
>                 Key: CB-7518
>                 URL: https://issues.apache.org/jira/browse/CB-7518
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugman
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> The Android SDK auto-detection code (e.g. location ANDROID_HOME, putting 
> things in your PATH), is a part of cordova-android's check_reqs script, which 
> is not called from within CLI. So, we don't want to rely on the presense of 
> the "android" executable from within CLI. 
> Currently the only time it's called is for `<framework>` within plugins. With 
> the ANDROID_HOME changes in 3.6.0, running this isn't necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to