[
https://issues.apache.org/jira/browse/CB-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Sorokin updated CB-8424:
----------------------------------
Description:
When compass is not supported on the device, Device Orientation plugin's
compass.hardwarecheck spec is failing.
Usually, pending state is used to mark the unsupported functionality but it
looks like due to jasmine limitations we cannot pend spec from async call so
the remaining options is make it green on leave it failing.
Since that missing compass is not a problem with the code but with device
itself, I suggest that we mark the check as green and leave all dependent tests
as pending.
was:
When compass is not supported on the device, Device Orientation plugin's
compass.hardwarecheck spec is failing.
Usually, pending state is used to mark the unsupported functionality but it
looks like due to jasmine limitations we cannot pend spec from async call so It
would be
> compass.hardwarecheck spec is failing instead of being pending
> --------------------------------------------------------------
>
> Key: CB-8424
> URL: https://issues.apache.org/jira/browse/CB-8424
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device Orientation
> Reporter: Alexander Sorokin
> Priority: Minor
>
> When compass is not supported on the device, Device Orientation plugin's
> compass.hardwarecheck spec is failing.
> Usually, pending state is used to mark the unsupported functionality but it
> looks like due to jasmine limitations we cannot pend spec from async call so
> the remaining options is make it green on leave it failing.
> Since that missing compass is not a problem with the code but with device
> itself, I suggest that we mark the check as green and leave all dependent
> tests as pending.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
