[
https://issues.apache.org/jira/browse/CB-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305695#comment-14305695
]
ASF GitHub Bot commented on CB-8425:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/43
CB-8425 Media plugin .ctr: make src param required as per spec
https://issues.apache.org/jira/browse/CB-8425
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-8425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 930ca840b6abd633eb26790fa89013f58fbd40a6
Author: sgrebnov <[email protected]>
Date: 2015-02-04T18:27:32Z
CB-8425 Media plugin .ctr: make src param required as per spec
----
> Media plugin .ctr: make src param required as per spec
> ------------------------------------------------------
>
> Key: CB-8425
> URL: https://issues.apache.org/jira/browse/CB-8425
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-plugin-media
>
> As per documentation src is a mandatory but in argscheck it is optional. Due
> to this in some unit tests 'undefined' is passed to native proxy and may
> cause some issues (for example I see related internal errors on Windows)
> var Media = function(src, successCallback, errorCallback, statusCallback) {
> argscheck.checkArgs('SFFF', 'Media', arguments);
> this.id = utils.createUUID();
> mediaObjects[this.id] = this;
> this.src = src;
> ...
> exec(null, this.errorCallback, "Media", "create", [this.id, this.src]);
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
