[
https://issues.apache.org/jira/browse/CB-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308806#comment-14308806
]
ASF GitHub Bot commented on CB-8407:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/63
CB-8407 Fix downloading of ms-appdata:/// urls on Windows
JIRA issue [CB-8407](https://issues.apache.org/jira/browse/CB-8407)
download() in file-transfer plugin expects path instead of internal URL on
windows
This bug seems to be introduced with these changes to cordova-plugin-file:
https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f
All tests for download method of file-transfer plugin now fail on windows
with following message:
```
Exception calling native with command :: FileTransfer :: download
::exception=WinRTError: The parameter is incorrect.
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer
CB-8407
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 0394c0ce1eaf60f93ef1d529bc2fe1634d5d33da
Author: Vladimir Kotikov <[email protected]>
Date: 2015-02-03T12:50:31Z
CB-8407 Removes excess path to native path conversion in download method
This fixes file transfer download tests failures, when target file is
specified by ms-appdata:/// uri on Windows.
commit 7a93626812522e473248c7629238da81d03fb805
Author: Vladimir Kotikov <[email protected]>
Date: 2015-02-03T14:06:14Z
CB-8407 Use File proxy to construct valid FileEntry for download success
callback
Due to changes in file plugin
(https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f)
result of download method should now have filesystemName specified for proper
work. This updates download method to construct FileEntry properly, using File
plugin proxy.
----
> file-transfer plugin fails to download a file if to ms-appdata specified file
> on windows
> ----------------------------------------------------------------------------------------
>
> Key: CB-8407
> URL: https://issues.apache.org/jira/browse/CB-8407
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Affects Versions: 0.4.8
> Environment: Windows platform
> File-transfer [email protected]
> file [email protected]
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: file, file-transfer, windows
>
> download() in file-transfer plugin expects path instead of internal URL on
> windows
> This bug seems to be introduced with these changes to cordova-plugin-file:
> https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f
> All tests for download method of file-transfer plugin now fail on windows
> with following message:
> Exception calling native with command :: FileTransfer :: download
> ::exception=WinRTError: The parameter is incorrect.
> As per internal discussion, this line may be the cause:
> https://github.com/apache/cordova-plugin-file-transfer/blob/master/src/windows/FileTransferProxy.js#L166
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
