[ 
https://issues.apache.org/jira/browse/CB-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312355#comment-14312355
 ] 

ASF GitHub Bot commented on CB-8227:
------------------------------------

Github user gorkem commented on the pull request:

    https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863
  
    IMHO it is(or was) premature to drop this single PR by itself to master. 
This new flag --save flag should replace the save command, save command is not 
removed by this PR. Consequently the existing tests for save command should 
also be modified/replaced to work with this new function.
    
    Also without the corresponding restore functionality --save is useless to 
CLI users. I think we should refrain from releasing it until restore is taken 
to master too


> Add --save option to 'cordova platform add'
> -------------------------------------------
>
>                 Key: CB-8227
>                 URL: https://issues.apache.org/jira/browse/CB-8227
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> When run with the --save flag, the 'platform add' command will not only add 
> the specified platforms, but it will also save them to config.xml.
> - When running this command, the pinned CLI version will be used if no 
> version is specified.
> - config.xml will be ovewritten if similar engine has already been specified 
> in config.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to