[
https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328745#comment-14328745
]
ASF GitHub Bot commented on CB-8515:
------------------------------------
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/59#discussion_r25058822
--- Diff: template/cordova/lib/prepare.js ---
@@ -40,14 +40,37 @@ module.exports.applyPlatformConfig = function () {
return false;
});
+ // Apply appxmanifest changes
['package.windows.appxmanifest', 'package.windows80.appxmanifest',
'package.phone.appxmanifest'].forEach(
function(manifestFile) {
updateManifestFile(config, path.join(ROOT, manifestFile));
});
+ // Apply jsproj changes
+ ['CordovaApp.Phone.jsproj', 'CordovaApp.Windows.jsproj',
'CordovaApp.Windows80.jsproj'].forEach(
+ function(jsprojFile) {
+ updatejsprojFile(config, path.join(ROOT, jsprojFile));
+ });
+
copyImages(config);
};
+function updatejsprojFile(config, jsProjFilePath) {
+ var defaultLocale = config.defaultLocale();
+
+ if (defaultLocale) {
--- End diff --
I think we should remove or set to default DefaultLanguage in case there is
no config.defaultLocale().
> Support DefaultLanguage selection for Windows
> ---------------------------------------------
>
> Key: CB-8515
> URL: https://issues.apache.org/jira/browse/CB-8515
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Reporter: Murat Sutunc
>
> The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute)
> supports "defaultlocale" attribute.
> Cordova should set the appropriate project file attributes for Windows 8.0,
> 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale"
> attribute.
> In the case widget is missing "defaultlocale" attribute, it should default to
> "en-us".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
