[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329387#comment-14329387
]
ASF GitHub Bot commented on CB-8499:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25095035
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -158,6 +160,11 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
return installPluginsForNewPlatform(platform,
projectRoot, cfg, opts);
}
}).then(function() {
+ // Save platform@version into platforms.json. i.e:
'android@https://github.com/apache/cordova-android.git'
+ // If no version was specified, save the edge version
+ var versionToSave = version ? version :
platforms[platform].version;
--- End diff --
just a nitpick - there is no need for ternary operator, `version ||
platforms[platform].version` will work the same way
> 'cordova platform save' : should save all installed platforms to config.xml
> ---------------------------------------------------------------------------
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
> Reporter: Omar Mefire
> Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
