[ 
https://issues.apache.org/jira/browse/CB-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336726#comment-14336726
 ] 

ASF GitHub Bot commented on CB-8534:
------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/82

    CB-8534: Add support for auth dialogs in inappbrowser plugin

    When an authentication challenge is received, the inappbrowser will now 
check to see if a plugin can respond to the challenge before going to the 
default behavior. This is the same behavior that was added to cordova-android 
in CB-8201. It allows plugins like [Auth 
Dialog](https://github.com/MSOpenTech/cordova-plugin-auth-dialog) to work with 
the inappbrowser.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit e607ac63eed97b420c07a328d7c6bfce6d9d49ec
Author: Connor Pearson <[email protected]>
Date:   2015-02-24T16:51:38Z

    CB-8534: Allow plugins to respond to onReceivedHttpAuthRequest

commit e3b1a06fe37dfdde55df7ce810c429390e25cf6f
Author: Connor Pearson <[email protected]>
Date:   2015-02-24T18:48:14Z

    If getPluginManager does not work access the field directly

----


> Add support for auth dialogs in inappbrowser plugin
> ---------------------------------------------------
>
>                 Key: CB-8534
>                 URL: https://issues.apache.org/jira/browse/CB-8534
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, Plugin InAppBrowser
>            Reporter: Connor Pearson
>
> The AndroidWebView delegates onReceivedHttpAuthRequest to any plugin that 
> responds to it. (CB-8201) This would add the same the same behavior to the 
> inappbrowser for android.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to