[
https://issues.apache.org/jira/browse/CB-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337899#comment-14337899
]
ASF GitHub Bot commented on CB-8544:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/34#discussion_r25405334
--- Diff: src/utils/createMedicJson.js ---
@@ -0,0 +1,16 @@
+// /usr/bin/env node
+/*jshint node: true*/
+
+var fs = require('fs'),
+ path = require('path'),
+ error_writer = require('../build/makers/error_writer');
+
+module.exports = function createMedicJson(output, sha, cfg) {
+ try {
+ console.log('Writing medic.json to ' + output);
+ var medic_config = '{"sha":"' + sha + '","couchdb":"' +
cfg.couchdb.host + '","couchdbext":"' + cfg.couchdb.exthost + '"}';
+ fs.writeFileSync(path.join(output, 'medic.json'), medic_config,
'utf-8');
+ } catch (e) {
--- End diff --
Why are we swallowing this exception and continuing - shouldn't we not
continue if this step fails.
> Refactor medic platform build scripts
> -------------------------------------
>
> Key: CB-8544
> URL: https://issues.apache.org/jira/browse/CB-8544
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: Alexander Sorokin
> Priority: Minor
>
> Platform build scripts ('android.js', 'windows.js' etc.) needs to be
> refactored and improved:
> iOS builder:
> * Wait for tests to complete using `testRunner` module
> * Check for test results using `testchecker` module
> Common issues:
> * some common functionality can be moved into a separate module to avoid code
> duplication
> * fix formatting issues
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
