[
https://issues.apache.org/jira/browse/CB-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353276#comment-14353276
]
ASF GitHub Bot commented on CB-8521:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26058485
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -134,7 +135,7 @@ module.exports = function plugin(command, targets,
opts) {
// Fetch the plugin first.
events.emit('verbose', 'Calling plugman.fetch on
plugin "' + target + '"');
- return plugman.raw.fetch(target, pluginsDir, {
searchpath: searchPath, noregistry: opts.noregistry, link: opts.link,
pluginInfoProvider: pluginInfoProvider});
+ return plugman.raw.fetch(target, pluginsDir, {
searchpath: searchPath, noregistry: opts.noregistry, link: opts.link,
pluginInfoProvider: pluginInfoProvider, variables: opts.cli_variables });
--- End diff --
Nit: Consider splitting this into two lines - it's rather wide currently -
preventing readability.
> 'cordova plugin save' should save all installed plugins and their
> version/git-url/folder-location into config.xml
> -----------------------------------------------------------------------------------------------------------------
>
> Key: CB-8521
> URL: https://issues.apache.org/jira/browse/CB-8521
> Project: Apache Cordova
> Issue Type: New Feature
> Reporter: Omar Mefire
> Assignee: Omar Mefire
>
> In addition to using 'cordova plugin add org.apache.cordova.device --save' to
> both add and save a plugin to config.xml, It would be useful to have a way to
> 'mass save' already installed plugins to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
