[
https://issues.apache.org/jira/browse/CB-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356398#comment-14356398
]
ASF GitHub Bot commented on CB-7698:
------------------------------------
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/184
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
FOO' should fail when no variables specified.
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
FOO' should fail when no variables specified.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-7698
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit a5098b7758d6ad11e7fa7f2b0b22090088103314
Author: Omar Mefire <[email protected]>
Date: 2015-03-11T06:46:07Z
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
FOO' should fail when no variables specified.
----
> CLI: no validation for globally required plugin variables
> ---------------------------------------------------------
>
> Key: CB-7698
> URL: https://issues.apache.org/jira/browse/CB-7698
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Bryan Higgins
> Assignee: Bryan Higgins
> Priority: Minor
>
> CLI should check that any globally required variables (preference at root
> level in plugin.xml) have been provided before calling plugman.install on the
> platforms. Otherwise the plugin is added to the project but plugman fails to
> install to any platforms.
> From the docs:
> plugman checks that these required preferences are passed in. If not, it
> should warn the user how to pass the variable in and exit with a non-zero
> code.
> http://cordova.apache.org/docs/en/3.6.0/plugin_ref_spec.md.html#Plugin%20Specification
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
