[
https://issues.apache.org/jira/browse/CB-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360282#comment-14360282
]
ASF GitHub Bot commented on CB-8670:
------------------------------------
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/185
CB-8670 Error when set engine name to "cordova-windows" in plugin.xml
If you create an `engine` element with `name="cordova-windows"` (rather
than `cordova-windows8`) in `plugin.xml`, like this:
```xml
<engines>
<engine name="cordova-windows" version=">=3.8.0" />
</engines>
```
You will get an error when you add the plugin:
```
TypeError: Cannot call method 'indexOf' of undefined
at ...\cordova-lib\src\plugman\install.js:232:45
```
The engines in `default-engines.js` had not been updated to support
`cordova-windows` as a platform name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 301d7381c323172b028875ac672c4298ed0d0bbc
Author: Tim Barham <[email protected]>
Date: 2015-03-13T12:25:03Z
CB-8670 Error when set engine name to "cordova-windows" in plugin.xml
If you create an engine element with name="cordova-windows" in plugin.xml,
like this:
<engines>
<engine name="cordova-windows" version=">=3.8.0" />
</engines>
You will get an error when you add the plugin:
TypeError: Cannot call method 'indexOf' of undefined
at ...\cordova-lib\src\plugman\install.js:232:45
----
> Error when set engine name to "cordova-windows" in plugin.xml
> -------------------------------------------------------------
>
> Key: CB-8670
> URL: https://issues.apache.org/jira/browse/CB-8670
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: Master
> Reporter: Tim Barham
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> If you create an engine element with name="cordova-windows" in plugin.xml,
> like this:
> {code:xml}
> <engines>
> <engine name="cordova-windows" version=">=3.8.0" />
> </engines>
> {code}
> You will get an error when you add the plugin:
> {noformat}
> TypeError: Cannot call method 'indexOf' of undefined
> at ...\cordova-lib\src\plugman\install.js:232:45
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
