[
https://issues.apache.org/jira/browse/CB-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368169#comment-14368169
]
Andrew Grieve commented on CB-7767:
-----------------------------------
Probably worth waiting one release to remove it so that the plugins aren't
dropping iOS 6 support before cordova-ios is. Want to keep our plugins
compiling against both 3.8.0 as well as 4.0.x, and don't want to drop iOS 6 in
plugins until cordova-ios drops it.
Don't feel too strong, but that's my 2c :)
> [iOS] Remove usage of NSData+Base64
> ------------------------------------
>
> Key: CB-7767
> URL: https://issues.apache.org/jira/browse/CB-7767
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Fix For: 4.0.0
>
>
> There is built in support since iOS 7. Once we drop iOS 6, we can do this.
> https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36
> Lines:
> 1.
> https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88
> 2.
> https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40
> Replace with:
> 1. [[NSData alloc] initWithBase64EncodedString:data options:0]
> 2. [data base64EncodedStringWithOptions:0]
> Test mobilespec bridge benchmark before this change and after, then report
> the results.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
