[ 
https://issues.apache.org/jira/browse/CB-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368293#comment-14368293
 ] 

ASF GitHub Bot commented on CB-8711:
------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-js/pull/106

    CB-8711 wait for all callbacks before evaluating expectations

    Some of the android (multi) exec call tests were failing on windows ( but 
not osx )
    Changed the tests so they wait for the correct number of callbacks before 
evaluating the 'expects' list.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-js CB-8711

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit eda207a905987b4ec4716f1d4b8d1e19bdf6fb6c
Author: Jesse MacFadyen <[email protected]>
Date:   2015-03-19T01:19:45Z

    CB-8711 wait for all callbacks before evaluating expectations

----


> Android exec tests fail on windows+appveyor
> -------------------------------------------
>
>                 Key: CB-8711
>                 URL: https://issues.apache.org/jira/browse/CB-8711
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>
> This appears to be a difference in the way async results are handled in 
> jasmine-node windows vs jasmine-node ios or some other lib.
> Tests likely just need a slight adjustment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to