[
https://issues.apache.org/jira/browse/CB-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382116#comment-14382116
]
ASF GitHub Bot commented on CB-8185:
------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/25#issuecomment-86594471
My bad :dizzy_face: Fixed in
https://github.com/apache/cordova-plugin-network-information/commit/481bdd93b023f808c301943ac6c541e3633aeee4
> Add online and offiline plugin-network-information events support for the
> Browser platform
> ------------------------------------------------------------------------------------------
>
> Key: CB-8185
> URL: https://issues.apache.org/jira/browse/CB-8185
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Browser, Plugin Network Information
> Reporter: Sergey Shakhnazarov
> Assignee: Vladimir Kotikov
>
> Initial implementation used XHR to check whether we connected to network or
> not. Two main problems of this approach is that it used CORS and wasn't able
> to detect local network access.
> So for better compatibility with specs it is better to use browsers native
> implementation of {{navigator.onLine}} property which properly handles all
> the aspects of network accessibility.
> {{navigator.onLine}} available for all modern browsers:
> http://caniuse.com/#feat=online-status
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
