[
https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382747#comment-14382747
]
ASF GitHub Bot commented on CB-8484:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27259466
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = function(options) {
var opts = parseOpts(options);
var builder = builders[opts.buildMethod];
- return builder.prepEnv()
+ return builder.prepEnv(opts)
.then(function() {
- return builder.clean(opts.extraArgs);
+ return builder.clean(opts);
}).then(function() {
shell.rm('-rf', path.join(ROOT, 'out'));
+ }).then(function() {
+ ['debug', 'release'].forEach(function(config) {
+ removeIfExists(path.join(ROOT, config + SIGNING_PROPERTIES));
--- End diff --
Good point. To delete these files the user has to explicitly run the
`clean` script from platforms\android\cordova. This made me think about other
scenarios as well for CLI workflow:
1. cordova build <nopackageInfo>
2. cordova build <packageInfo>
3. cordova build <nopackageInfo>
The third invocation will use the pacakgeInfo from the previous invocation
as I do not delete debug-signing.properties & release-signing.properies.
I can make this a bit more sophisticated to account for non-CLI workflows -
detect if the file is auto-generated (It has the canned comment ("Do not modify
this file -- YOUR CHANGES WILL BE ERASED")). If it is then I go ahead and
delete it not only on `clean` but also when starting a build with no package
info specified.
> Cordova package support for Android
> -----------------------------------
>
> Key: CB-8484
> URL: https://issues.apache.org/jira/browse/CB-8484
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
> Affects Versions: 4.0.0
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
