[
https://issues.apache.org/jira/browse/CB-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383820#comment-14383820
]
ASF GitHub Bot commented on CB-8756:
------------------------------------
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/195
CB-8756 Make 'plugin --save' work more like 'npm install'
1. `plugin add --save` now always saves version (in the form `^x.y.z`)
2. `plugin add --save` now always overwrites an existing entry.
3. `plugin add` now honors an existing version specified in `config.xml`
when a plugin is added without a specific version, even if the `--save` flag is
specified.
I also fixed a bug in `isUrl()` (in `util.js`) - `url.protocol` includes
the colon, so the protocol for a windows path is something like `c:` - 2
characters, not one.
Note that I'm current finishing off a similar change for `platform add
--save`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit b79ca83e64dd8f485209370d9ff1b113ba32d9f2
Author: Tim Barham <[email protected]>
Date: 2015-03-27T13:22:20Z
CB-8756 Make plugin --save work more like npm install.
1. 'plugin add --save' now always saves version (in the form '^x.y.z')
2. 'plugin add --save' now always overwrites an existing entry.
3. 'plugin add' now honors an existing version specified in config.xml when
a plugin is added without a specific version, even if the '--save' flag is
specified.
I also fixed a bug in isUrl() in util.js - url.protocol includes the colon,
so the protocol for a windows path is something like "c:" - 2 characters, not
one.
----
> Make plugin --save work more like npm install --save
> ----------------------------------------------------
>
> Key: CB-8756
> URL: https://issues.apache.org/jira/browse/CB-8756
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Tim Barham
> Assignee: Tim Barham
> Original Estimate: 4m
> Remaining Estimate: 4m
>
> 1. {{plugin add --save}} doesn't save version by default - it should always
> save version (in the form {{^x.y.z}})
> 2. {{plugin add --save}} never overwrites an existing entry - it should
> always overwrite an existing entry.
> 3. An existing version specified in {{config.xml}} is ignored when plugin is
> added without a specific version, but with the {{--save}} option - version in
> {{config.xml}} should be honored.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
