[
https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387745#comment-14387745
]
ASF GitHub Bot commented on CB-8484:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446076
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -297,6 +320,14 @@ var builders = {
var distributionUrl =
'distributionUrl=http\\://services.gradle.org/distributions/gradle-2.2.1-all.zip';
var gradleWrapperPropertiesPath = path.join(projectPath,
'gradle', 'wrapper', 'gradle-wrapper.properties');
shell.sed('-i', distributionUrlRegex, distributionUrl,
gradleWrapperPropertiesPath);
+ }).then(function() {
--- End diff --
nit: don't need this to be in a separate promise.
> Cordova package support for Android
> -----------------------------------
>
> Key: CB-8484
> URL: https://issues.apache.org/jira/browse/CB-8484
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
> Affects Versions: 4.0.0
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
