[
https://issues.apache.org/jira/browse/CB-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392126#comment-14392126
]
ASF GitHub Bot commented on CB-8785:
------------------------------------
GitHub user SangChan opened a pull request:
https://github.com/apache/cordova-ios/pull/134
[CB-8785] add try/catch for evalJS:
evalJS's javascript starts with cordova.require.
If there's no cordova object? Show's big alert view. So add try/catch for
evalJS:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SangChan/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 4bbc56805425da2c4aabc5adee6aeaa0460a7d14
Author: SangChan Lee <[email protected]>
Date: 2015-04-02T04:28:13Z
[CB-8785] add try/catch for evalJS:
----
> evalJS's javascript need try/catch.
> -----------------------------------
>
> Key: CB-8785
> URL: https://issues.apache.org/jira/browse/CB-8785
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 3.5.0
> Reporter: SangChanLee
> Fix For: Master
>
>
> Sometimes, There's no cordova object on html files. But, unfortunately
> CVViewController calls some notification using notification center and call
> evalJS using these method. (cordova.fireDocumentEvent('resign'),
> cordova.fireDocumentEvent('resume'), cordova.fireDocumentEvent('active'),
> cordova.fireDocumentEvent('pause')).
> But evalJS's javascript starts with cordova.require. So, at that time there's
> no cordova object? Show's big alert view.
> Need try/catch for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
