[ 
https://issues.apache.org/jira/browse/CB-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487572#comment-14487572
 ] 

ASF subversion and git services commented on CB-8807:
-----------------------------------------------------

Commit 87c9f230b45cd9c6119a5b5b17c26ec041d1a0b6 in cordova-lib's branch 
refs/heads/master from [~TimBarham]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=87c9f23 ]

CB-8807 Platform Add fails to add plugins with variables.

When a plugin that uses variables is automatically installed for a new
platform, it fails with the following exception:

    Installing "[plugin]" for [platform]
    Failed to install '[plugin]':Error: Variable(s) missing: [variables]
        at .../cordova-lib/src/plugman/install.js:299:23
        at ...

The problem here is that we are looking in config.xml for information about
the plugins variables, but the plugin is only saved to config.xml if it was
added with the --save flag. This fix updates the logic to look in fetch.json
instead.

GitHub: close #205


> Platform Add fails to add plugins with variables
> ------------------------------------------------
>
>                 Key: CB-8807
>                 URL: https://issues.apache.org/jira/browse/CB-8807
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> *Steps:*
> 1.Create a cordova project
> 2.Add plugin with variables (like the facebook plugin)
> 3.Add android platform 
> *Result:*
> Failed to add plugin with error:
> {noformat}
> Installing "[plugin]" for [platform]
> Failed to install '[plugin]':Error: Variable(s) missing: [variables]
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:299:23
>     at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54)
>     at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30)
>     at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13)
>     at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:557:44
>     at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17)
>     at process._tickCallback (node.js:355:11)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to