[
https://issues.apache.org/jira/browse/CB-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499918#comment-14499918
]
ASF GitHub Bot commented on CB-8872:
------------------------------------
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-blackberry/pull/182
CB-8872 Add parens to disambiguate ! / instanceof
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry cb_8872
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-blackberry/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit c42525b6c0210d5edee0544c1cddd69c9d858834
Author: Josh Soref <[email protected]>
Date: 2015-04-17T14:37:02Z
CB-8872 Add parens to disambiguate ! / instanceof
----
> jshint 2.7.0 breaks on current code
> -----------------------------------
>
> Key: CB-8872
> URL: https://issues.apache.org/jira/browse/CB-8872
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
> Affects Versions: Master
> Reporter: Jenny Gee
> Priority: Minor
>
> {quote}
> /var/jenkins/workspace/cordova-blackberry$ node_modules/grunt-cli/bin/grunt
> Running "jshint:all" (jshint) task
> framework/lib/utils.js
> 53 | if (!arg instanceof Array) {
> ^ Confusing use of '!'.
> 58 | if (!arg instanceof Date) {
> ^ Confusing use of '!'.
> >> 2 errors in 90 files
> Warning: Task "jshint:all" failed. Use --force to continue.
> {quote}
> This doesn't break on [email protected]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
