[ 
https://issues.apache.org/jira/browse/CB-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507237#comment-14507237
 ] 

ASF GitHub Bot commented on CB-8804:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28882307
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -632,73 +645,79 @@ else if (destType == FILE_URI || destType == 
NATIVE_URI) {
          */
         public void onActivityResult(int requestCode, int resultCode, Intent 
intent) {
     
    -        // Get src and dest types from request code for a Camera Activity
    -        int srcType = (requestCode / 16) - 1;
    -        int destType = (requestCode % 16) - 1;
    -
    -        // If Camera Crop
    -        if (requestCode >= CROP_CAMERA) {
    -            if (resultCode == Activity.RESULT_OK) {
    +        if (this.imageUri == null && this.getPictureFromGallery == false) {
    --- End diff --
    
    Would it be more appropriate to check if `callbackContext == null`? An app 
can be evicted even when getting a picture from the gallery.


> https://github.com/apache/cordova-plugin-camera#android-quirks
> --------------------------------------------------------------
>
>                 Key: CB-8804
>                 URL: https://issues.apache.org/jira/browse/CB-8804
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>         Environment: Android
>            Reporter: Serge Huijben
>            Priority: Trivial
>
> Android Quirks
> Android uses intents to launch the camera activity on the device to capture 
> images, and on phones with low memory, the Cordova activity may be killed. In 
> this scenario, the image may not appear when the Cordova activity is restored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to