[
https://issues.apache.org/jira/browse/CB-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543748#comment-14543748
]
ASF GitHub Bot commented on CB-9025:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/217
CB-9025 Call windows `prepare` logic on as part of cordova-lib `prepare`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9025
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 17a8496871aa0c73b318bc2007666b7ba17a825e
Author: Vladimir Kotikov <[email protected]>
Date: 2015-05-13T15:55:39Z
CB-9025 Call windows `prepare` logic on as part of cordova-lib `prepare`
----
> Call platform-specific 'prepare' logic on windows as part of the 'prepare'
> step
> -------------------------------------------------------------------------------
>
> Key: CB-9025
> URL: https://issues.apache.org/jira/browse/CB-9025
> Project: Apache Cordova
> Issue Type: Task
> Components: CordovaLib, Windows
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> All of the 'prepare' logic of windows is called as part of build and this
> makes other tools and hooks to plug in correctly difficult.
> The proposed approach is to require and execute this logic inside of
> cordova-lib {{prepare}} method like this is done for android here:
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L565
>
> However, to avoid this logic to be called twice (from cordova-lib {{prepare}}
> and platfrom's {{build}}) we need to remove {{applyPlatformConfig}} call from
> build script.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
