[
https://issues.apache.org/jira/browse/CB-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547754#comment-14547754
]
ASF GitHub Bot commented on CB-8441:
------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-js/pull/112
CB-8441 add platforms as devdeps and cordova-js-src to build cordova.js
* Use legacy-exec/platform when cordova-js-src is not available
* updated grunt workflow to not require platformVersion flag anymore to
build. Instead grab platform version info from platform dependencies.
* fix bug with browserify workflow where multiple platforms caused
incorrect symbolList + asyc issues when adding modules
* both `grunt compile:browserify` and `grunt compile` are supported.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-js CB-8441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 6c7765e53bed09b88713956861dc9cd085baad2b
Author: Steve Gill <[email protected]>
Date: 2015-05-06T18:21:07Z
CB-8441 added platforms as dev dependencies
commit 65344c1b127d58151b12105bad0f5e993aad8738
Author: Steve Gill <[email protected]>
Date: 2015-05-12T00:10:38Z
if no --platformVersion, set it to N/A instead of failing
commit 2c7cf57f9655965a627ee54447ba79c53c6bafac
Author: Steve Gill <[email protected]>
Date: 2015-05-12T01:23:08Z
CB-8441 grunt compile now uses platform dependencies cordova-js-src for
platform specific exec files
commit 156e26053f471095d0bf8298793f8b575e6ba597
Author: Steve Gill <[email protected]>
Date: 2015-05-16T00:12:55Z
CB-8441 updated workflow to use cordova-js-src when available
commit cb234634f072f049ade498968c5aa9888dd7611c
Author: Steve Gill <[email protected]>
Date: 2015-05-18T07:59:43Z
CB-8441 platformVersion flag not required anymore. Grab version from
dependecy platform versions
----
> Delete platform specific src from cordovajs, update browserify and grunt
> build flow
> -----------------------------------------------------------------------------------
>
> Key: CB-8441
> URL: https://issues.apache.org/jira/browse/CB-8441
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaJS
> Reporter: Steve Gill
> Assignee: Steve Gill
>
> Delete platform specific src from cordovajs since it has been moved to
> platforms (CB-8417)
> Update browserify builds to look in platform cordova-js-src folder when
> building cordova-js
> Update grunt cordova-js builds to look in platform folders for platform
> specific js
> Doc at
> https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
