[ 
https://issues.apache.org/jira/browse/CB-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Polivy updated CB-9060:
---------------------------
    Description: 
With [email protected] and the new whitelist functionality, it seems that 
calls to CordovaWebView.showWebPage (via CordovaWebViewImpl implementation) are 
getting launched both in the app WebView AND via Intent in the system browser.

This happens when, for example, the Cordova app is hosted remotely, so the 
actual URL is a http://www.somedomain.com/url, and the developer has included 
the following in config.xml:

    <!-- Allow links to web pages to open in a browser -->
    <allow-intent href="http://*/*"; />
    <allow-intent href="https://*/*"; />

Then, if in the app, there is a call to showWebPage with a URL at 
http://www.somedomain.com, it will launch in both places.

Should there be a return statement at Line 216 to prevent any attempt to load 
the URL externally, if we actually load it internally?

https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaWebViewImpl.java#L216


  was:
With [email protected] and the new whitelist functionality, it seems that 
calls to CordovaWebView.showWebPage (via CordovaWebViewImpl implementation) are 
getting launched both in the app WebView AND via Intent in the system browser.

This happens when, for example, the Cordova app is hosted remotely, so the 
actual URL is a http://www.somedomain.com/url, and the developer has included 
the following in config.xml:

    <!-- Allow links to web pages to open in a browser -->
    <allow-intent href="http://*/*"; />
    <allow-intent href="https://*/*"; />

Should there be a return statement at Line 216 to prevent any attempt to load 
the URL externally, if we actually load it internally?

https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaWebViewImpl.java#L216



> [Android] CordovaWebViewImpl.showWebPage loads in WebView AND launches intent
> -----------------------------------------------------------------------------
>
>                 Key: CB-9060
>                 URL: https://issues.apache.org/jira/browse/CB-9060
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Dan Polivy
>
> With [email protected] and the new whitelist functionality, it seems that 
> calls to CordovaWebView.showWebPage (via CordovaWebViewImpl implementation) 
> are getting launched both in the app WebView AND via Intent in the system 
> browser.
> This happens when, for example, the Cordova app is hosted remotely, so the 
> actual URL is a http://www.somedomain.com/url, and the developer has included 
> the following in config.xml:
>     <!-- Allow links to web pages to open in a browser -->
>     <allow-intent href="http://*/*"; />
>     <allow-intent href="https://*/*"; />
> Then, if in the app, there is a call to showWebPage with a URL at 
> http://www.somedomain.com, it will launch in both places.
> Should there be a return statement at Line 216 to prevent any attempt to load 
> the URL externally, if we actually load it internally?
> https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaWebViewImpl.java#L216



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to