[ 
https://issues.apache.org/jira/browse/CB-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557267#comment-14557267
 ] 

ASF GitHub Bot commented on CB-8783:
------------------------------------

Github user msct commented on the pull request:

    https://github.com/apache/cordova-docs/pull/276#issuecomment-104879485
  
    I'll offer my two cents.  Yes, ambiguous and technically correct, and 
that's why `default` should have probably always been the device default.  But 
these are the semantics which describe the intent and goal of Cordova as a 
whole....
    
    I don't use Cordova for device defaults.  We use Cordova for a familiar 
development pattern and a consistent experience across all devices.  Having a 
root-level orientation preference which allows for unrestricted orientation 
accomplishes that.
    
    As @shazron suggested, I am very much in favor of an **all**, or **any** 
value.  It's one thing to change an already well-documented config.xml *naming 
peculiarity*, but it's another thing to remove it outright and force code 
changes. Lots of love guys.


> 'default' value for Orientation does not support both landscape and portrait 
> orientations.
> ------------------------------------------------------------------------------------------
>
>                 Key: CB-8783
>                 URL: https://issues.apache.org/jira/browse/CB-8783
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.8.0
>            Reporter: Nikhil Khandelwal
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: cordova-ios-4.0.x
>
> There is no support for adding both landscape and portrait orientation for 
> iOS as can be seen by the plist value for 'default'
> https://github.com/apache/cordova-lib/blob/8de97feba2fa883298eb9c99be0c425c73960f1a/cordova-lib/src/cordova/metadata/ios_parser.js#L84



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to