[
https://issues.apache.org/jira/browse/CB-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563875#comment-14563875
]
ASF GitHub Bot commented on CB-9094:
------------------------------------
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49
CB-9094: Smarter autohide logic on Android
When the plugin is initialized, the splash screen is shown with an
auto-hide delay. If a subsequent call to show() comes in while the
splashscreen is visible, it will still be automatically hidden, even
though the user expectation is that it wouldn't be.
This fix tracks the "hideAfterDelay" setting of the most recent call to
show() -- and when the auto hide timer goes off, if the most recent call
to show() did not set hideAfterDelay, then the splashscreen will not be
automatically hidden.
This provides a more consistent -- and expected -- behavior based on
user action.
Fixes https://issues.apache.org/jira/browse/CB-9094
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB9094
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit c9165dbea3939388e12f96f03ca47b5a7724140d
Author: Dan Polivy <[email protected]>
Date: 2015-05-28T23:20:21Z
CB-9094: Smarter autohide logic on Android
When the plugin is initialized, the splash screen is shown with an
auto-hide delay. If a subsequent call to show() comes in while the
splashscreen is visible, it will still be automatically hidden, even
though the user expectation is that it wouldn't be.
This fix tracks the "hideAfterDelay" setting of the most recent call to
show() -- and when the auto hide timer goes off, if the most recent call
to show() did not set hideAfterDelay, then the splashscreen will not be
automatically hidden.
This provides a more consistent -- and expected -- behavior based on
user action.
https://issues.apache.org/jira/browse/CB-9094
----
> [android] Splashscreen is incorrectly hidden after delay if show is called
> with no timeout
> ------------------------------------------------------------------------------------------
>
> Key: CB-9094
> URL: https://issues.apache.org/jira/browse/CB-9094
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Reporter: Dan Polivy
> Priority: Minor
>
> The Android SplashScreen plugin's showSplashScreen() method takes a parameter
> that determines whether the splashscreen should be hidden after a
> configurable delay. If an initial call to show the splash screen comes in
> with a delay, but while it is visible a second call comes in to show the
> splashscreen WITHOUT a delay, the splash screen will still be removed after
> the initial delay.
> In this scenario, I would expect that, due to the second call to show without
> auto-hiding, the splash screen would stay visible until the hide() method is
> called.
> Repro steps:
> 1. Splash screen is automatically shown on startup (e.g.
> showSplashScreen(true) is called in plugin initializer). If no
> SplashScreenDelay is specified in config.xml, then a default of 3s is used.
> 2. While the splash screen is still visible, the user calls
> navigator.splashscreen.show() from code (meaning it should be shown without a
> timeout, e.g. showSplashScreen(false) is called from onMessage).
> Actual:
> Splash screen disappears after delay.
> Expected:
> Splash screen should stay visible until hide() is explicitly called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
