[
https://issues.apache.org/jira/browse/CB-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579111#comment-14579111
]
ASF GitHub Bot commented on CB-9119:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/180#discussion_r32027602
--- Diff: bin/templates/cordova/lib/retry.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+/* jshint node: true */
+
+"use strict";
+
+/*
+ * Retry a promise-returning function attemts_left times, propagating its
+ * results on success or throwing its error on a failed final attempt.
+ *
+ * Takes a number of attempts, a promise-returning function, and all its
+ * arguments (as trailing arguments).
+ */
+module.exports.retryPromise = function (attemts_left, promiseFunction) {
+
+ // NOTE:
+ // get all trailing arguments, by skipping the first two
(attemts_left and
+ // promiseFunction) because they shouldn't get passed to
promiseFunction
+ var promiseFunctionArguments = Array.prototype.slice.call(arguments,
2);
+
+ return promiseFunction.apply(undefined, promiseFunctionArguments).then(
+
+ // on success pass results through
+ function onFulfilled(value) {
+ return value;
+ },
+
+ // on rejection either retry, or throw the error
+ function onRejected(error) {
+
+ attemts_left -= 1;
+
+ if (attemts_left < 1) {
+ throw error;
+ }
+
+ console.log("call failed; retrying " + attemts_left + " more
time(s)");
--- End diff --
There is no unified way to do verbose logging - every platform &
cordova-lib does it a little bit differently. I have not seen any code in
Android platform doing it altogether. If you decide to keep these messages,
consider reformatting.
> ADB install in automation sometimes hangs the emulator
> ------------------------------------------------------
>
> Key: CB-9119
> URL: https://issues.apache.org/jira/browse/CB-9119
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: Master
> Reporter: Dmitry Blotsky
> Assignee: Dmitry Blotsky
> Priority: Critical
> Labels: adb, android, hang, hard_to_verify
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Sometimes "adb install ..." hangs indefinitely when running "cordova run"
> under medic. Jenkins also sees this. Related links below.
> Android bug: http://code.google.com/p/android/issues/detail?id=10255
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
