[
https://issues.apache.org/jira/browse/CB-9122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582614#comment-14582614
]
ASF GitHub Bot commented on CB-9122:
------------------------------------
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32275358
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -43,17 +54,101 @@ if (host.match(/win/)) {
}
*/
-// Just use Android everywhere; we're mocking out any calls to the
`android` binary.
-module.exports.testPlatform = 'android';
+module.exports.setEngineSpec = function (appPath, spec) {
+ appPath = getConfigPath(appPath);
+ var parser = new ConfigParser(appPath);
+
+ parser.removeEngine(module.exports.testPlatform);
+ parser.addEngine(module.exports.testPlatform, spec);
+ parser.write();
+};
+
+module.exports.getEngineSpec = function (appPath) {
--- End diff --
consider making this function more general by allowing the engine to be
passed in as a separate parameter, instead of using the global variable
module.exports.testPlatform.
> Implement integration tests for platform and plugin save/restore feature
> ------------------------------------------------------------------------
>
> Key: CB-9122
> URL: https://issues.apache.org/jira/browse/CB-9122
> Project: Apache Cordova
> Issue Type: Task
> Components: CordovaLib
> Reporter: Alexander Sorokin
>
> List of integration tests and scenarios to be written :
>
> CORDOVA PLATFORM/PLUGIN ADD TESTS :
> - Ensure that support for custom .tgz files is still enabled (VS
> depends on this)
> - cordova platform add android --save [empty config.xml]
> - cordova platform add android --save [config.xml already contains
> [email protected]]
> - cordova platform add android --save [config.xml contains
> android@file://C:/path/to/android]
> - cordova platform add [email protected] --save [invalid version => in
> this case, install should fail and should not update config.xml]
> - cordova platform add C://path/to/android/platform --save
> - support for custom branch checkout : cordova platform add
> https://github.com/apache/cordova-android.git#2.6.x
> - cordova plugin add cordova-plugin-console –save [config.xml empty]
> - cordova plugin add cordova-plugin-console –save [config.xml
> already contains [email protected]]
> - cordova plugin add facebook-plugins –variables … –save [testing
> variables support]
> - cordova plugin add git_url
> - cordova plugin add local_folder
>
> CORDOVA PLATFORM/PLUGIN REMOVE TESTS :
> - cordova platform remove android --save [config.xml is empty]
> - cordova platform remove android --save [config.xml contains
> android@C:/path/to/android/platform]
> - cordova plugin remove plugin-id --save [config.xml is empty]
> - cordova plugin remove plugin-id --save [config.xml contains
> git-url of plugin]
>
> CORDOVA PLATFORM/PLUGIN UPDATE TESTS :
> - cordova platform update [email protected] --save [config.xml already
> contains [email protected]]
> - support for git-urls : cordova platform update
> https://github.com/apache/cordova-android.git –save
> - cordova plugin update cordova-plugin-console --save
> - cordova plugin update [email protected] --save
>
> MASS-SAVE TESTS :
> - cordova platform save [no platforms installed => no update to
> config.xml]
> - cordova platform save [with some platforms installed]
> - cordova plugin save [no plugins installed => no update to
> config.xml]
> - cordova plugin save [with some plugins installed: one with
> version, one with local folder and another one via git cloning]
>
> PLATFORM/PLUGIN RESTORATION :
> - cordova prepare => should restore all platforms and plugins
> - cordova prepare android
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
