[ 
https://issues.apache.org/jira/browse/CB-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585672#comment-14585672
 ] 

ASF GitHub Bot commented on CB-8214:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-coho/pull/60#issuecomment-111986557
  
    Re-based and re-tested. I  see that there was similar fix added here: 
https://github.com/apache/cordova-coho/commit/5a07ec0c711e16695e2ce5a824ae5fee9cf5897f
 
    But it is still actual since it removes unnecessary logic as well.


> COHO. Rename windowsphone to wp8 to be consistent
> -------------------------------------------------
>
>                 Key: CB-8214
>                 URL: https://issues.apache.org/jira/browse/CB-8214
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Coho
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>
> COHO currently uses windowsphone target name to refer wp8. For consistency 
> reasons we should use wp8. Also, due to this it requires additional checks in 
> code code to replace windowsphone string to wp8 to pass correct target 
> platform name to other tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to