[
https://issues.apache.org/jira/browse/CB-9162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586548#comment-14586548
]
ASF GitHub Bot commented on CB-9162:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/247#discussion_r32458071
--- Diff: cordova-lib/spec-plugman/install-browserify.spec.js ---
@@ -46,6 +46,7 @@ var install = require('../src/plugman/install'),
'com.cordova.engine-android' : path.join(plugins_dir,
'com.cordova.engine-android'),
'org.test.plugins.childbrowser' : path.join(plugins_dir,
'org.test.plugins.childbrowser'),
'com.adobe.vars' : path.join(plugins_dir, 'com.adobe.vars'),
+ 'org.test.defaultvariables' : path.join(plugins_dir,
'org.test.defaultvariables'),
--- End diff --
@ogoguel - could you make the equivalent change to `install.spec.js`?
> Plugin Variables should support a default value
> -----------------------------------------------
>
> Key: CB-9162
> URL: https://issues.apache.org/jira/browse/CB-9162
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: Olivier Goguel
>
> When declaring a variable, it is possible to make it mandatory (by using the
> <preference> tag), but there's no way to make it optional by defining a
> default value.
> For example: <preference value="ENABLE_LOG" default="true" />
> This would allow users to keep on customizing specific features of the
> plugins while not having to worry about all the variables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
