[
https://issues.apache.org/jira/browse/CB-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587276#comment-14587276
]
ASF GitHub Bot commented on CB-9114:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/234#discussion_r32483383
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
}
}
+ if (opts.usegit) {
+ msg = '\r\nWARNING: The --usegit flag has been deprecated ! \r\n' +
+ 'instead, please use: `cordova platform add
git-url#custom-branch`. \r\n' +
+ 'e.g: cordova platform add
https://github.com/apache/cordova-android.git#2.4.0 \r\n';
+ events.emit('log', msg);
--- End diff --
Some nits:
* Use `\n`, not `\r\n`.
* Use `\'` rather than backtick (`` ` ``).
* Use `events.emit('warning'...)`
* No space before `!` (or even just a period - no need to get too excited
:smile:).
* Capital `I` for `Instead`
> Deprecate --usegit flag
> -----------------------
>
> Key: CB-9114
> URL: https://issues.apache.org/jira/browse/CB-9114
> Project: Apache Cordova
> Issue Type: Task
> Components: Docs
> Reporter: Omar Mefire
> Assignee: Omar Mefire
>
> This issue is to track work done on documenting the new feature 'platform and
> plugin version management'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
