[ 
https://issues.apache.org/jira/browse/CB-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603149#comment-14603149
 ] 

ASF GitHub Bot commented on CB-9252:
------------------------------------

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/93#discussion_r33372216
  
    --- Diff: bin/lib/create.js ---
    @@ -98,6 +106,16 @@ module.exports.run = function (argv) {
         return Q.resolve();
     };
     
    +function recursiveCreateDirectory(targetPath) {
    +    var parent = path.join(targetPath, '..');
    +    if (!fs.existsSync(parent)) {
    +        recursiveCreateDirectory(parent);
    +    }
    +
    +    console.log('Creating directory "' + targetPath + '"');
    --- End diff --
    
    Heh... Do we really want to be notified about each directory we're creating 
in the path? If we need any notification, I'd prefer just a single one (so at 
the call point rather than here).


> Migrate WinJS to NPM dependency
> -------------------------------
>
>                 Key: CB-9252
>                 URL: https://issues.apache.org/jira/browse/CB-9252
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows
>    Affects Versions: 4.0.0
>            Reporter: Rob Paveza
>            Assignee: Rob Paveza
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to