[
https://issues.apache.org/jira/browse/CB-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605908#comment-14605908
]
ASF GitHub Bot commented on CB-9159:
------------------------------------
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-116763083
In general LGTM.
I would prefer that we examine the pipeline here. We had been talking
about making the build process be module-based for Windows (for example, the
Windows build step provides a set of require()-able modules that then executes
from cordova-lib). In such a world, we could just parse the CLI arguments once
up-front, instead of making each individual step parse them, which seems to
have increased the complexity as we talk about build vs run vs prepare. I'd
like to see us go that direction in the long-term, but in the short-term, I
think this will be adequate.
> Fix Windows Phone 8.1 deploy when 'window-target-version' is 10.0
> -----------------------------------------------------------------
>
> Key: CB-9159
> URL: https://issues.apache.org/jira/browse/CB-9159
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: windows, windows-phone
>
> I'm using the following configuration to upgrade desktop app to Windows10 and
> continue using 8.1 for Windows Phone target.
> {code}
> <preference name="windows-target-version" value="10.0" />
> <preference name="windows-phone-target-version" value="8.1" />
> {code}
> Deploy to Phone fails as it incorrectly tries to find and deploy Windows10
> package
> {code}
> λ cordova run windows -- --phone
> Running command: cmd "/s /c
> "C:\temp\winDeployTest\platforms\windows\cordova\run.bat --phone""
> MSBuildToolsPath: C:\Program Files (x86)\MSBuild\14.0\bin\amd64\
> Building project:
> C:\temp\winDeployTest\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform : anycpu
> CordovaApp.Phone ->
> C:\temp\winDeployTest\platforms\windows\AppPackages\CordovaApp.Phone_0.0.1.0_anyc
> pu_debug_Test\CordovaApp.Phone_0.0.1.0_anycpu_debug.appx
> CordovaApp.Phone ->
> C:\temp\winDeployTest\platforms\windows\AppPackages\CordovaApp.Phone_0.0.1.0_anyc
> pu_debug.appxupload
> Your package has been successfully created.
> ERROR: Package with specified parameters not found in AppPackages folder
> ERROR running one or more of the platforms: Error: cmd: Command failed with
> exit code 2
> You may not have the required environment or OS to run this project
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
